[PATCH] D7241: Partially fix memcpy / memset / memmove lowering in SelectionDAG construction if address space != 0.

hfinkel@anl.gov via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 10 10:44:52 PST 2015


hfinkel added a subscriber: hfinkel.
hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D7241#307161, @mjacob wrote:

> ping
>
> I think this won't get in the way of implementing a more comprehensive solution to the memory intrinsic lowering problem. Instead I see it as a first step. However, as we don't really seem to come to a conclusion here, I wonder whether it makes sense to discuss the problem in a broader scope first (on the mailing list).


I agree; this is a reasonable incremental step. When some target actually wants to do the "right" thing here for the more-general case, adding the associated infrastructure will be straightforward. Without such a use case, however, the error is the best we can do.

LGTM.


http://reviews.llvm.org/D7241





More information about the llvm-commits mailing list