[PATCH] D14851: Add Branch Hints for Highly Biased Branches on PPC

[hfinkel@anl.gov via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

Please remember to upload your patches with full context (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).

A few minor comments, otherwise LGTM.


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:39
@@ -36,2 +38,3 @@
 #include "llvm/Target/TargetOptions.h"
+
 using namespace llvm;
----------------
Please don't make unrelated white-space changes along with functional changes.

================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:58
@@ -54,1 +57,3 @@
 
+static cl::opt<bool> EnableBranchHint(
+    "ppc-use-branch-hint",
----------------
Is there further testing you wish to do before enabling this by default? If not, then let's enable it.


http://reviews.llvm.org/D14851