[PATCH] D15084: Split the linker in 2

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 20:06:45 PST 2015


tejohnson added inline comments.

================
Comment at: lib/Linker/LinkModules.cpp:70
@@ -440,4 +69,3 @@
   bool emitError(const Twine &Message) {
-    DiagnosticHandler(LinkDiagnosticInfo(DS_Error, Message));
-    HasError = true;
+    Mover.getDiagnosticHandler()(LinkDiagnosticInfo(DS_Error, Message));
     return true;
----------------
tejohnson wrote:
> Comment needs to be updated.
Ignore this, somehow this one ended up in the wrong place.

================
Comment at: lib/Linker/LinkModules.cpp:127
@@ -519,1 +126,3 @@
 
+  /// Promote local variables so that they can be reference externally by
+  /// thin lto imported globals.
----------------
This was the comment that I intended to say needed an update.


http://reviews.llvm.org/D15084





More information about the llvm-commits mailing list