[compiler-rt] r255170 - [CMake] Provide options for toggling on and off various runtime libraries.

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 16:44:46 PST 2015


I’m tracking a few bot failures as fallout of this change, so I’ve decided to revert the change. Hopefully I’ll get some time later this week to work out the kinks.

Sorry for the breakage.

-Chris

> On Dec 9, 2015, at 4:36 PM, Hans Wennborg <hans at chromium.org> wrote:
> 
> I'm getting build failures on Windows with this commit in range:
> http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/5252/steps/gclient%20runhooks/logs/stdio
> 
> Basically, it's now building lib\interception\interception_win.cc in
> 64-bit mode and hitting an #error. I don't think we used to build that
> file before.
> 
> Any idea what might have caused that? I don't know how the cmake files
> in compiler-rt work.
> 
> On Wed, Dec 9, 2015 at 2:45 PM, Chris Bieneman via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: cbieneman
>> Date: Wed Dec  9 16:45:03 2015
>> New Revision: 255170
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=255170&view=rev
>> Log:
>> [CMake] Provide options for toggling on and off various runtime libraries.
>> 
>> Summary:
>> Rather than having to add new "experimental" options each time someone wants to work on bringing a sanitizer to a new platform, this patch makes options for all of them.
>> 
>> The default values for the options are set by the platform checks that would have enabled them, but they can be overridden on or off.
>> 
>> Reviewers: kubabrecka, samsonov
>> 
>> Subscribers: llvm-commits
>> 
>> Differential Revision: http://reviews.llvm.org/D14846



More information about the llvm-commits mailing list