[PATCH] D15211: [ProfileData] Add unit test infrastructure for sample profile reader/writer

[Nathan Slingerland via llvm-commits]

slingn marked 2 inline comments as done.

================
Comment at: include/llvm/ProfileData/SampleProfWriter.h:61
@@ -61,3 +60,3 @@
   static ErrorOr<std::unique_ptr<SampleProfileWriter>>
-  create(StringRef Filename, SampleProfileFormat Format);
+  create(raw_ostream &OutputStream, SampleProfileFormat Format);
 
----------------
davidxl wrote:
> why changing this interface? It is not like the stream based create method is used multiple different places.
OK. Having a reference to the ostream (and caller owning it) would be slightly cleaner but precludes us having a factory method that takes a file name since somebody has to own the ostream.

I'll put that back and switch back to unique_ptr<raw_ostream>.


http://reviews.llvm.org/D15211