[PATCH] D11438: Part 2 to fix x86_64 fp128 calling convention.

[Chih-Hung Hsieh via llvm-commits]

chh added inline comments.

================
Comment at: lib/Target/X86/X86InstrInfo.td:957-962
@@ -956,7 +956,8 @@
 
-def loadi8  : PatFrag<(ops node:$ptr), (i8  (load node:$ptr))>;
-def loadi64 : PatFrag<(ops node:$ptr), (i64 (load node:$ptr))>;
-def loadf32 : PatFrag<(ops node:$ptr), (f32 (load node:$ptr))>;
-def loadf64 : PatFrag<(ops node:$ptr), (f64 (load node:$ptr))>;
-def loadf80 : PatFrag<(ops node:$ptr), (f80 (load node:$ptr))>;
+def loadi8   : PatFrag<(ops node:$ptr), (i8  (load node:$ptr))>;
+def loadi64  : PatFrag<(ops node:$ptr), (i64 (load node:$ptr))>;
+def loadf32  : PatFrag<(ops node:$ptr), (f32 (load node:$ptr))>;
+def loadf64  : PatFrag<(ops node:$ptr), (f64 (load node:$ptr))>;
+def loadf80  : PatFrag<(ops node:$ptr), (f80 (load node:$ptr))>;
+def loadf128 : PatFrag<(ops node:$ptr), (f128 (load node:$ptr))>;
 
----------------
davidxl wrote:
> It seems you are adding extra space before :
Yes, it seems to be the style at line 964-969 too.


================
Comment at: lib/Target/X86/X86InstrSSE.td:8871
@@ +8870,3 @@
+
+def : Pat<(X86fand FR128:$src1, FR128:$src2),
+          (COPY_TO_REGCLASS (ANDPSrr (COPY_TO_REGCLASS FR128:$src1, VR128),
----------------
davidxl wrote:
> Is there any coding style guidelines for table gen code? There are long lines that are wrapped ..
Note sure if there is special rule for table gen code.
http://llvm.org/docs/CodingStandards.html says 80 columns.
There are few exceptions in this file,
but now I wrapped all my new lines to less than 80 characters.


================
Comment at: test/CodeGen/X86/fp128-calling-conv.ll:15
@@ +14,3 @@
+
+define i64 @TestParam_L_0(i64 %d0, i64 %d1, i64 %d2, i64 %d3, i64 %d4, i64 %d5, i64 %d6, i64 %d7, i64 %d8, i64 %d9, i64 %d10, i64 %d11, i64 %d12, i64 %d13, i64 %d14, i64 %d15, i64 %d16, i64 %d17, i64 %d18, i64 %d19) {
+entry:
----------------
davidxl wrote:
> Is this a relevant test? non-f128 related tests can be submitted in a different patch.
Okay, i will put non-fp128 type tests to another patch.


================
Comment at: test/CodeGen/X86/fp128-cast.ll:12
@@ +11,3 @@
+
+define void @TestCastF32_I32() {
+entry:
----------------
davidxl wrote:
> There are also lots of irrelevant tests added in this file .
Okay, i will put non-fp128 type tests to another patch.



http://reviews.llvm.org/D11438