[PATCH] D15308: [tsan] Support aarch64 for Android.

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: lib/tsan/rtl/tsan_platform.h:129
@@ +128,3 @@
+
+#else
+
----------------
yabinc wrote:
> eugenis wrote:
> > Is there a reason you are not using the generic aarch64/linux mappings below?
> > For ASan/aarch64/android, I've noticed that ART requires a first 4GB mapping, which seems incompatible with this layout.
> > 
> The Android mapping is different from Mapping39 in kLoAppMemBeg-kLoAppMemEnd. Because
> android links all executables as shared libraries.
> Thanks for reminding. I didn't notice that. I will check it out after my vacation.
You mean PIE?
That linux mapping does not support PIE!
Well it could be a kernel version thing - at some point they moved PIE executable mappings from 0x7f.. to 0x55...

I've added a comment to http://reviews.llvm.org/D14199.

I don't mind going ahead with this one and figuring out if we want to unify the mappings later.



http://reviews.llvm.org/D15308