[PATCH] D15365: Cross-DSO control flow integrity (LLVM part)

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 14:48:38 PST 2015


pcc added inline comments.

================
Comment at: include/llvm/Transforms/IPO/CrossDSOCFI.h:22
@@ +21,3 @@
+uint64_t BuildCFICallSiteTypeId(StringRef S);
+
+}
----------------
Oh, I see that you need this in the frontend. I wonder if there's a better way to do this that doesn't involve the frontend and the pass conspiring to use the same hash values? Maybe the bitset identifiers should be hash values in cross-DSO mode?


Repository:
  rL LLVM

http://reviews.llvm.org/D15365





More information about the llvm-commits mailing list