[PATCH] D15387: [compiler-rt] [msan] Variadic support for AArch64

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 11:04:07 PST 2015


eugenis added inline comments.

================
Comment at: lib/msan/msan.cc:58
@@ -57,3 +57,3 @@
 SANITIZER_INTERFACE_ATTRIBUTE
-THREADLOCAL u64 __msan_va_arg_tls[kMsanParamTlsSize / sizeof(u64)];
+ALIGNED(16) THREADLOCAL u64 __msan_va_arg_tls[kMsanParamTlsSize / sizeof(u64)];
 
----------------
This only aligns the first element of the array. Why is that sufficient?
Do you need to change instrumentation as well to align each next store location to 16 bytes?



http://reviews.llvm.org/D15387





More information about the llvm-commits mailing list