[PATCH] D15334: PC-relative support for EmitValue

Kyungwoo Lee via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 10:21:40 PST 2015


kyulee1 added a reviewer: enderby.
kyulee1 updated this revision to Diff 42315.
kyulee1 added a comment.

Updated the changes -- no default value under MCTargetDesc. 
I'm not sure how to add a standalone test unless we want to extend an asm syntax like .pcrel and implement it using this. 
Since this API does not alter the default behavior, but I don't think testing is really necessary as long as build is successful.

Added a reviewer, Kevin -- I just picked from the log who added SMLoc argument to EmitValue.
Can you please take a look?


http://reviews.llvm.org/D15334

Files:
  include/llvm/MC/MCELFStreamer.h
  include/llvm/MC/MCObjectStreamer.h
  include/llvm/MC/MCStreamer.h
  lib/MC/MCAsmStreamer.cpp
  lib/MC/MCELFStreamer.cpp
  lib/MC/MCObjectStreamer.cpp
  lib/MC/MCStreamer.cpp
  lib/Target/AArch64/MCTargetDesc/AArch64ELFStreamer.cpp
  lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
  lib/Target/Mips/MCTargetDesc/MipsELFStreamer.cpp
  lib/Target/Mips/MCTargetDesc/MipsELFStreamer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15334.42315.patch
Type: text/x-patch
Size: 9511 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151209/aeecbab0/attachment.bin>


More information about the llvm-commits mailing list