[PATCH] D15132: [X86][SSE] Update the cost table for integer-integer conversions on SSE2.

[Simon Pilgrim via llvm-commits]

RKSimon added inline comments.

================
Comment at: lib/Target/X86/X86TargetTransformInfo.cpp:703
@@ +702,3 @@
+    { ISD::ZERO_EXTEND, MVT::v4i16,  MVT::v4i8,   1 },
+    { ISD::SIGN_EXTEND, MVT::v4i16,  MVT::v4i8,   6 },
+
----------------
congh wrote:
> RKSimon wrote:
> > These values don't appear to be correct for SSE41 which has PMOVSX/PMOVZX ops - maybe split off the 128-bit extension ops from AVXConversionTbl into SSE41ConversionTbl ?
> SSSE3 also provides pshufb from which several operations here can benefit. So you suggestion adding more tables for SSSE3/SSE4.1?
You may not need SSSE3 (often PSHUFB is as costly as fixed shuffles on older hardware - it just reduces register use) but splitting the extensions from AVX into SSE41 needs to be done.

================
Comment at: lib/Target/X86/X86TargetTransformInfo.cpp:724
@@ -694,3 +723,3 @@
   }
 
   if (ST->hasAVX512()) {
----------------
I haven't checked this very thoroughly but you might need to improve non-simple type handling here, especially for extensions?


http://reviews.llvm.org/D15132