[PATCH] D15257: AMDGPU/SI: Emit constant arrays in the .text section

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 15:09:22 PST 2015


tstellarAMD added a comment.

In http://reviews.llvm.org/D15257#303271, @arsenm wrote:

> Can you use a bundle instead of creating a pseudo with a special pass required to expand it? I've started working on using bundles for soft clauses so the passes necessary for those will be run anyway


I was unable to get this work.  I kept getting


================
Comment at: lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:339
@@ -338,2 +338,3 @@
   addPass(createSILowerControlFlowPass(*TM), false);
+  addPass(&FinalizeMachineBundlesID, false);
 }
----------------
arsenm wrote:
> Oh, I missed this before. I think this might need to run earlier but I'm not sure
I'm not really sure either.  I was a little concerned that having it earlier might break the existing passes which may be using the wrong type of instruction iterator for handling bundles.


http://reviews.llvm.org/D15257





More information about the llvm-commits mailing list