[PATCH] D14827: Adding support for missing variations of X86 string related instructions

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 14:09:22 PST 2015


On Sun, Dec 6, 2015 at 10:23 AM, Marina Yatsina <marina.yatsina at intel.com>
wrote:

> myatsina added a comment.
>
> Sean, if I understand correctly, you, as well as Reid, support producing a
> warning, though the spec explicitly mentions that the memory operand is
> ignored, and though MSVC and ICC do not produce such warnings, right?
> If so, how about some kind of warning like "Memory operand ignored,
> assuming ES:(R|E)SI" or something of that sort?
>

I think that if the spec is willing to include a paragraph warning about
this, the assembler probably should warn about it as well. I would say
"memory operand is only for determining the size, ES:(R|E)DI will be used
for the destination" (as it says in the spec) instead of "memory operand
ignored, assuming ES:(R|E)SI".

-- Sean Silva


>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D14827
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151208/5273eb14/attachment.html>


More information about the llvm-commits mailing list