[PATCH] D15323: Add Available Externally linkage type to isWeakForLinker()

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 13:37:03 PST 2015


Yes, sorry. I think my review was wrong.

It would be reasonable for isWeakForLinker to return true iff it
returned true for declarations, which is not the case.

Sorry,
Rafael


On 8 December 2015 at 14:10, Peter Collingbourne <peter at pcc.me.uk> wrote:
> pcc added a subscriber: pcc.
> pcc added a comment.
>
> I don't think this is right. It basically reverts part of http://reviews.llvm.org/D10941.
>
> Should we instead fix globaldce to do the right thing with these types of globals?
>
>
> http://reviews.llvm.org/D15323
>
>
>


More information about the llvm-commits mailing list