[PATCH] D14687: Macro support in LLVM IR

[David Blaikie via llvm-commits]

On Tue, Dec 8, 2015 at 9:04 AM, Amjad Aboud via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> aaboud added a comment.
>
> In http://reviews.llvm.org/D14687#304938, @aprantl wrote:
>
> > The only concern I've got with this is whether we shouldn't future-proof
> this by using the DWARF5-style DW_MACRO_.* constants internally, since the
> old ones aren't even defined in the DWARF5 standard document any more and
> thus might be harder to find documentation for.
> >
> > Context: In DWARF5 ( http://dwarfstd.org/ShowIssue.php?issue=110722.1 )
> the DW_MACINFO_.* constants will be renamed to DW_MACRO_*. This will be fun
> to implement in dwarfdump because the same numeric value has different
> names depending on the DWARF version.
>
>
> Thanks Adrian for the comment.
> I understand your concern, but I think it is not related to this patch of
> macro support in LLVM IR.
>

It is in the sense that the LLVM IR support uses the DWARF macro names
(indeed this patch introduces those DWARF enums into llvm/Support/Dwarf.h,
etc). So the question is whether we should use the DW_MACINFO names instead.


> I intentionally, split code into several parts, so the concern can be
> raised only on the problematic ones.
>
> Do you think that this patch might not fit DWARF5?
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D14687
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151208/9f3db476/attachment.html>