[PATCH] D15270: PassManagerInternal: remove unused parameters. NFC.

[David Blaikie via llvm-commits]

On Tue, Dec 8, 2015 at 1:37 AM, Francis Visoiu Mistrih via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Hello Philip,
>
> The 12/07/2015 10:43, Philip Reames wrote:
> > I think this patch - and the others of similar vein you've posted - are
> flat
> > out a bad idea.  They diminish readability for no gain.  Do you have a
> good
> > argument for why unnamed parameters are a good idea?
> The unused parameters cause warinings [-Wunused-parameter].
>

But we don't have that warning enabled, do we? (at least the Clang
self-hosting build doesn't seem to ever trigger it, so I assume we don't
have it enabled)


>
> Would commenting the parameter names, or casting them to void in the
> body of the function be a better idea?
>
> --
> Francis Visoiu Mistrih
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151208/247a8be8/attachment.html>