[PATCH] D14687: Macro support in LLVM IR

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 08:51:11 PST 2015


aprantl added a comment.

The only concern I've got with this is whether we shouldn't future-proof this by using the DWARF5-style DW_MACRO_.* constants internally, since the old ones aren't even defined in the DWARF5 standard document any more and thus might be harder to find documentation for.

Context: In DWARF5 ( http://dwarfstd.org/ShowIssue.php?issue=110722.1 ) the DW_MACINFO_.* constants will be renamed to DW_MACRO_*. This will be fun to implement in dwarfdump because the same numeric value has different names depending on the DWARF version.


Repository:
  rL LLVM

http://reviews.llvm.org/D14687





More information about the llvm-commits mailing list