[PATCH] D15080: [asan] Reports suppressions for ASan recovery mode (compiler-rt part).

Maxim Ostapenko via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 07:01:23 PST 2015


m.ostepenko updated this revision to Diff 42169.
m.ostepenko added a comment.

Okay, let's do another try.

New patch implements a lock-free approach (thanks Yura for idea!) based on CAS. The only drawback of the method is that we should iterate over AsanBuggyPcPool from it's beginning each time we perform lookup, that may become a performance bottleneck. However, this way we managed to avoid races on AsanBuggyPcPool without using mutex and the only race we have is on **pc_num** counter, used for fast path (early returning) only. So, I wonder, if something like this can resolve the issue?


http://reviews.llvm.org/D15080

Files:
  lib/asan/asan_rtl.cc
  lib/sanitizer_common/sanitizer_flags.inc
  test/asan/TestCases/Posix/halt_on_error-signals.c
  test/asan/TestCases/Posix/halt_on_error-torture.cc
  test/asan/TestCases/halt_on_error-2.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15080.42169.patch
Type: text/x-patch
Size: 8382 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151208/8095c813/attachment.bin>


More information about the llvm-commits mailing list