[PATCH] D15320: CodeGen: Redo analyzePhysRegs() and computeRegisterLiveness()

[Sanjoy Das via llvm-commits]

sanjoy added a comment.

Minor nits inline.


================
Comment at: include/llvm/CodeGen/MachineInstrBundle.h:169
@@ -169,4 +168,3 @@
   struct PhysRegInfo {
-    /// Clobbers - Reg or an overlapping register is defined, or a regmask
-    /// clobbers Reg.
-    bool Clobbers;
+    /// A regmask clobbers Reg.
+    bool Clobbered;
----------------
Please add a one-liner about what 'clobbers' means.

================
Comment at: lib/CodeGen/MachineInstrBundle.cpp:328
@@ -331,1 +327,3 @@
+      if (Covered)
+        PRI.FullyDefined = true;;
       if (!MO.isDead())
----------------
Nit: repeated `;` s.


Repository:
  rL LLVM

http://reviews.llvm.org/D15320