[PATCH] D12781: PGO IR-level instrumentation infrastructure

[Justin Bogner via llvm-commits]

Rong Xu <xur at google.com> writes:
> Sean, Justin and David: Do you have any comment on the latest patch?
> If it looks fine to you, I plan to submit it again this week.

I believe the latest patch has addressed all of my comments, thanks. I'm
fine with this as long as you have an LGTM from Sean or David, since
they've both been looking at this in more detail than I have.

> Thanks!
>
> -Rong
>
> On Wed, Dec 2, 2015 at 3:37 PM, Rong Xu <xur at google.com> wrote:
>> xur updated this revision to Diff 41686.
>> xur added a comment.
>>
>> Integrated most recent review comments from Sean, David and Justin.
>> Let me know if I missed anything.
>>
>> Thanks,
>>
>> -Rong
>>
>>
>> http://reviews.llvm.org/D12781
>>
>> Files:
>>   include/llvm/IR/DiagnosticInfo.h
>>   include/llvm/InitializePasses.h
>>   include/llvm/LinkAllPasses.h
>>   include/llvm/Transforms/Instrumentation.h
>>   lib/IR/DiagnosticInfo.cpp
>>   lib/Transforms/Instrumentation/CFGMST.h
>>   lib/Transforms/Instrumentation/CMakeLists.txt
>>   lib/Transforms/Instrumentation/Instrumentation.cpp
>>   lib/Transforms/Instrumentation/LLVMBuild.txt
>>   lib/Transforms/Instrumentation/PGOInstrumentation.cpp
>>   test/Transforms/PGOProfile/Inputs/branch1.proftext
>>   test/Transforms/PGOProfile/Inputs/branch2.proftext
>>   test/Transforms/PGOProfile/Inputs/criticaledge.proftext
>>   test/Transforms/PGOProfile/Inputs/diag.proftext
>>   test/Transforms/PGOProfile/Inputs/landingpad.proftext
>>   test/Transforms/PGOProfile/Inputs/loop1.proftext
>>   test/Transforms/PGOProfile/Inputs/loop2.proftext
>>   test/Transforms/PGOProfile/Inputs/switch.proftext
>>   test/Transforms/PGOProfile/branch1.ll
>>   test/Transforms/PGOProfile/branch2.ll
>>   test/Transforms/PGOProfile/criticaledge.ll
>>   test/Transforms/PGOProfile/diag_mismatch.ll
>>   test/Transforms/PGOProfile/diag_no_funcprofdata.ll
>>   test/Transforms/PGOProfile/diag_no_profile.ll
>>   test/Transforms/PGOProfile/landingpad.ll
>>   test/Transforms/PGOProfile/loop1.ll
>>   test/Transforms/PGOProfile/loop2.ll
>>   test/Transforms/PGOProfile/single_bb.ll
>>   test/Transforms/PGOProfile/switch.ll
>>