[PATCH] D15191: [ELF] Support PHDRS command

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 11:18:08 PST 2015


ruiu added inline comments.

================
Comment at: ELF/Writer.cpp:866
@@ +865,3 @@
+  SmallMapVector<StringRef, IndicesVector, 8> PhdrsToFill = PhdrNameToIndices;
+  std::vector<StringRef> PhdrNames;
+  bool NewPhdrs = false;
----------------
I wanted to split this into multiple functions -- this function is 90 lines long which feels too long to me.


http://reviews.llvm.org/D15191





More information about the llvm-commits mailing list