[PATCH] D15288: tsan: fix test invisible barrier

[Alexey Samsonov via llvm-commits]

samsonov added a subscriber: samsonov.

================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:2701
@@ +2700,3 @@
+extern "C" SANITIZER_INTERFACE_ATTRIBUTE
+void __tsan_invisible_barrier_init(u64 *barrier, u32 count) {
+  if (count >= (1 << 8)) {
----------------
If these are only used in tests, can we name this `__tsan_testonly_invisible_barrier_init`?

================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:2719
@@ +2718,3 @@
+      return;
+    internal_sched_yield();
+  }
----------------
This doesn't match commit message (SleepForMillis).

================
Comment at: test/tsan/load_shared_lib.cc:6
@@ -5,3 +5,3 @@
 // RUN: %clangxx_tsan -O1 %s -DBUILD_SO -fPIC -shared -o %t-so.so
-// RUN: %clangxx_tsan -O1 %s -o %t && %deflake %run %t | FileCheck %s
+// RUN: %clangxx_tsan -O1 %s -o %t -rdynamic && %deflake %run %t | FileCheck %s
 
----------------
Why do you need this? I thought all `__tsan` symbols should be properly exported from executable...


http://reviews.llvm.org/D15288