[PATCH] D12841: [LLVMdev] Compiler-RT - Enabling ThreadSanitizer on PPC64(BE/LE) platforms

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 07:08:03 PST 2015


dvyukov accepted this revision.
dvyukov added a comment.

LGTM with a nit


================
Comment at: lib/tsan/rtl/tsan_platform_linux.cc:247
@@ -246,3 +246,3 @@
     (MostSignificantSetBitIndex(GET_CURRENT_FRAME()) + 1);
-  if (vmaSize != 39 && vmaSize != 42) {
+  if (vmaSize != 39 && vmaSize != 42 && vmaSize != 44 && vmaSize != 46) {
     Printf("FATAL: ThreadSanitizer: unsupported VMA range\n");
----------------
Please split this check per-architecture. Current numbers (39 and 42) are for aarch64. Otherwise we will end up allowing just any vma size.


http://reviews.llvm.org/D12841





More information about the llvm-commits mailing list