[PATCH] D13829: [IR] Move optional data in llvm::Function into a hungoff uselist

Keno Fischer via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 6 17:54:07 PST 2015


>
> Somehow using `ConstantPointerNull`s here seems really strange to me.
> I don't think we should be adding uses of `ConstantPointerNull` just
> as a placeholder.
>
> On the other hand, I'm not sure I have a better suggestion.  Can
> someone else give their opinion?  Is this fine?
>
> (If you can get me shouted down at that point, then this patch LGTM.)
>

I think the only other alternative is to have a variable number of operands
(with some canonical order
depending on which of personality/prefix/prologue is actually present), but
that seems like it would
get ugly quickly.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151206/e0931db9/attachment.html>


More information about the llvm-commits mailing list