[PATCH] D14706: [lit] Implement support of per test timeout in lit.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 6 02:51:25 PST 2015


delcypher added a comment.

In http://reviews.llvm.org/D14706#303390, @cmatthews wrote:

> I think needing a package that is not included in the Python standard release this is a serious issue. lit has no dependencies. That makes it easy to build and test anywhere.


It is not a hard dependency. It is only required if you want use the per test timeout. If you don't use the timeout lit will work fine without `pustil`. Although it would be nice to not have psutil as a dependency I'd like to point out that:

- Installing pustil is ridiculously easy. If you are root its just a single command`pip install psutil`, if you're not root you can just use `virtualenv` and then install it there.
- Not using `pustil` will likely lead to less portability (at least initially). The `pustil` module is awesome and a lot of hard work has gone into making it work on all platforms. It's likely that our attempts to emulate this work inside lit would not be as portable.
- lit is used by llvm developers or it is obtained via the package on PyPi. In the PyPi case `pustil` can be made a dependency so users will automatically get `pustil`. In the case for LLVM developers I believe that they are competent enough to know how to install `pustil` if they need it.


http://reviews.llvm.org/D14706





More information about the llvm-commits mailing list