[llvm] r254868 - [llvm-readobj] report_error() does not return, so we can simplify.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 5 15:36:53 PST 2015


Author: davide
Date: Sat Dec  5 17:36:52 2015
New Revision: 254868

URL: http://llvm.org/viewvc/llvm-project?rev=254868&view=rev
Log:
[llvm-readobj] report_error() does not return, so we can simplify.

Modified:
    llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp

Modified: llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp?rev=254868&r1=254867&r2=254868&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp (original)
+++ llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp Sat Dec  5 17:36:52 2015
@@ -296,10 +296,8 @@ static std::error_code createDumper(cons
 static void dumpObject(const ObjectFile *Obj) {
   StreamWriter Writer(outs());
   std::unique_ptr<ObjDumper> Dumper;
-  if (std::error_code EC = createDumper(Obj, Writer, Dumper)) {
+  if (std::error_code EC = createDumper(Obj, Writer, Dumper))
     reportError(Obj->getFileName(), EC);
-    return;
-  }
 
   outs() << '\n';
   outs() << "File: " << Obj->getFileName() << "\n";
@@ -414,10 +412,8 @@ static void dumpInput(StringRef File) {
 
   // Attempt to open the binary.
   ErrorOr<OwningBinary<Binary>> BinaryOrErr = createBinary(File);
-  if (std::error_code EC = BinaryOrErr.getError()) {
+  if (std::error_code EC = BinaryOrErr.getError())
     reportError(File, EC);
-    return;
-  }
   Binary &Binary = *BinaryOrErr.get().getBinary();
 
   if (Archive *Arc = dyn_cast<Archive>(&Binary))




More information about the llvm-commits mailing list