[PATCH] D14687: Macro support in LLVM IR

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 4 10:13:54 PST 2015


The IR changes LGTM.  Please wait for an LGTM from Adrian or David or Eric
(unless you've already had one?) for the broader direction.

> On 2015-Dec-04, at 07:40, Amjad Aboud <amjad.aboud at intel.com> wrote:
> 
> aaboud updated this revision to Diff 41878.
> aaboud added a comment.
> 
> Followed Duncan comment and moved "macros" field in DICompileUnit to be before "dwoId" field in all places (including API and textual LLVM IR) except bitcode, where "dwoId" is emitted before "macros" for backward compatibility.
> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D14687
> 
> Files:
>  docs/LangRef.rst
>  include/llvm/Bitcode/LLVMBitCodes.h
>  include/llvm/IR/DebugInfoMetadata.h
>  include/llvm/IR/Metadata.def
>  include/llvm/IR/Metadata.h
>  include/llvm/Support/Dwarf.h
>  lib/AsmParser/LLLexer.cpp
>  lib/AsmParser/LLParser.cpp
>  lib/AsmParser/LLToken.h
>  lib/Bitcode/Reader/BitcodeReader.cpp
>  lib/Bitcode/Writer/BitcodeWriter.cpp
>  lib/IR/AsmWriter.cpp
>  lib/IR/DIBuilder.cpp
>  lib/IR/DebugInfoMetadata.cpp
>  lib/IR/LLVMContextImpl.h
>  lib/IR/Verifier.cpp
>  lib/Support/Dwarf.cpp
>  test/Assembler/debug-info.ll
>  test/Assembler/dicompileunit.ll
>  unittests/IR/MetadataTest.cpp
> 
> <D14687.41878.patch>



More information about the llvm-commits mailing list