[PATCH] D15232: [InstCombine] Aggressively fold compares that can be discovered to be constant

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 4 09:16:38 PST 2015


jmolloy removed rL LLVM as the repository for this revision.
jmolloy updated this revision to Diff 41889.
jmolloy added a comment.

Hi David,

Thanks for the quick review! All the auto's done apart from one due to a strange type deduction error:

  error: variable 'IncValue' with type 'auto *' has incompatible initializer of type 'llvm::Use'
      for (auto *IncValue : PN->incoming_values())

Unfortunately isa<> can't be deduced as a UnaryPredicate either, which is a pity because I thought that would look really neat.

Cheers,

James


http://reviews.llvm.org/D15232

Files:
  include/llvm/Analysis/ValueTracking.h
  lib/Analysis/ValueTracking.cpp
  lib/Transforms/InstCombine/InstCombineCompares.cpp
  test/Transforms/InstCombine/icmp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15232.41889.patch
Type: text/x-patch
Size: 6513 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151204/0263511b/attachment.bin>


More information about the llvm-commits mailing list