[PATCH] D15139: [IR] Reformulate LLVM's EH funclet IR

[Reid Kleckner via llvm-commits]

rnk added inline comments.

================
Comment at: lib/Analysis/EHPersonalities.cpp:54
@@ +53,3 @@
+  // For any block B, the "colors" of B are the set of funclets F (possibly
+  // including a root "funclet" representing the main function), such that
+  // F will need to directly contain B or a copy of B (where the term "directly
----------------
I think the comment means that the list of colors may include the entry block, which isn't strictly speaking a funclet.

================
Comment at: lib/AsmParser/LLParser.cpp:5189-5190
@@ -5273,5 +5188,4 @@
   BasicBlock *UnwindBB = nullptr;
-  if (Lex.getKind() == lltok::kw_to) {
-    Lex.Lex();
-    if (ParseToken(lltok::kw_caller, "expected 'caller' in terminatepad"))
+  if (EatIfPresent(lltok::kw_to)) {
+    if (ParseToken(lltok::kw_caller, "expected 'caller' in catchswitch"))
       return true;
----------------
I like staying consistent with invoke, which does "unwind label %foo".


http://reviews.llvm.org/D15139