[PATCH] D15080: [asan] Reports suppressions for ASan recovery mode (compiler-rt part).

[Kostya Serebryany via llvm-commits]

kcc added inline comments.

================
Comment at: lib/asan/asan_rtl.cc:128
@@ +127,3 @@
+  // Race here, because some other thread may increase pc_num. This would lead
+  // to some pool entries would contain zeroes. This is OK, because we don't
+  // need exact presicion. Don't use atomic write due to performance issue.
----------------
phrasing? extra would? 

Also, it's enough to iterate from pc_num-1 to avoid the race 

================
Comment at: test/asan/TestCases/Posix/halt_on_error-torture.cc:11
@@ -10,3 +10,3 @@
 // Collisions are unlikely but still possible so we need the ||.
-// RUN: %env_asan_opts=halt_on_error=false %run %t 10 20 >10.txt 2>&1 || true
+// RUN: %env_asan_opts=halt_on_error=false ASAN_SUPPRESS_EQUAL_PCS=0 %run %t 10 20 >10.txt 2>&1 || true
 // This one is racy although _very_ unlikely to fail:
----------------
What's ASAN_SUPPRESS_EQUAL_PCS for? 

================
Comment at: test/asan/TestCases/halt_on_error-2.c:7
@@ +6,3 @@
+volatile int ten = 10;
+unsigned kNumIterations = 10;
+
----------------
Instead of creating a separate test it better to use a different RUN line with another --check-prefix. 


http://reviews.llvm.org/D15080