[PATCH] D15000: [ELF] - Implemented @tlsgd optimization (GD->IE case, x64).

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits.


================
Comment at: ELF/Target.cpp:499
@@ -494,4 +498,3 @@
     return false;
-  return Type == R_X86_64_TLSLD || Type == R_X86_64_DTPOFF32 ||
-         (Type == R_X86_64_TLSGD && !canBePreempted(S, true)) ||
-         (Type == R_X86_64_GOTTPOFF && !canBePreempted(S, true));
+  return (Type == R_X86_64_TLSGD || Type == R_X86_64_TLSLD ||
+          Type == R_X86_64_DTPOFF32 ||
----------------
Remove the outermost ().

================
Comment at: ELF/Target.cpp:548
@@ +547,3 @@
+// x86-x64 linker optimizations, http://www.akkadia.org/drepper/tls.pdf) shows
+// how
+// GD can be optimized to IE:
----------------
Remove newline at end of this line.


http://reviews.llvm.org/D15000