[PATCH] D15190: [mips][ias] Range check uimm6 operands and fix a bug this revealed.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 07:04:19 PST 2015


dsanders created this revision.
dsanders added a reviewer: vkalintiris.
dsanders added a subscriber: llvm-commits.
Herald added a subscriber: dsanders.

We don't check the size operand on ext/dext*/ins/dins* yet because the
permitted range depends on the pos argument and we can't check that using
this mechanism.

The bug was that dextu/dinsu accepted 0..31 in the pos operand instead of 32..63.

http://reviews.llvm.org/D15190

Files:
  lib/Target/Mips/AsmParser/MipsAsmParser.cpp
  lib/Target/Mips/MicroMips64r6InstrInfo.td
  lib/Target/Mips/Mips64InstrInfo.td
  lib/Target/Mips/MipsInstrInfo.td
  lib/Target/Mips/MipsMSAInstrInfo.td
  test/MC/Mips/micromips64r6/invalid.s
  test/MC/Mips/micromips64r6/valid.s
  test/MC/Mips/mips32r2/invalid.s
  test/MC/Mips/mips64r2/invalid.s
  test/MC/Mips/msa/invalid-64.s
  test/MC/Mips/msa/invalid.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15190.41752.patch
Type: text/x-patch
Size: 33786 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151203/9f4eeffd/attachment.bin>


More information about the llvm-commits mailing list