[PATCH] D15134: Part 1 to fix x86_64 fp128 calling convention.

[Sean Silva via llvm-commits]

silvas added a comment.

In http://reviews.llvm.org/D15134#300978, @chh wrote:

> It would be easier to keep track of these changes together, right?


No, it is actually the opposite. The more fine-grained the individual commits, the easier it is for a reviewer to review, and the easier it is to identify what caused an issue if an issue does show up. Tests are also easier to write for fine-grained commits (or, it is easier to identify that a fine-grained commit does not change externally visible behavior and so doesn't require a test).

Also, the changes you are proposing here seem to fix bugs / introduce new functionality. Therefore tests are required.


http://reviews.llvm.org/D15134