[PATCH] D15139: [IR] Reformulate LLVM's EH funclet IR

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 18:03:14 PST 2015


majnemer added inline comments.

================
Comment at: include/llvm/IR/Instructions.h:3861
@@ +3860,3 @@
+  void setUnwindDest(BasicBlock *UnwindCase) {
+    assert(hasUnwindDest());
+    setOperand(1, UnwindCase);
----------------
Done.

================
Comment at: include/llvm/IR/Instructions.h:3889
@@ +3888,3 @@
+  /// Returns a read/write iterator that points one past the last
+  /// in the CatchSwitchInst.
+  op_iterator handler_end() { return op_end(); }
----------------
Done.

================
Comment at: include/llvm/IR/Instructions.h:4163
@@ +4162,3 @@
+  /// \brief Methods for support type inquiry through isa, cast, and dyn_cast:
+  static inline bool classof(const Instruction *I) {
+    return I->getOpcode() == Instruction::CatchPad;
----------------
The way I saw it, the outer scope of a catchpad is it's catchswitch.


http://reviews.llvm.org/D15139





More information about the llvm-commits mailing list