[PATCH] D15133: [CMake] Add option LLVM_EXTERNALIZE_DEBUGINFO

Frederic Riss via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 13:39:35 PST 2015


friss added a comment.

>From what I understand this looks fine, but I fear that I'm not CMake-savvy enough to approve it.


================
Comment at: cmake/modules/AddLLVM.cmake:1183
@@ +1182,3 @@
+
+      set(lto_object ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${name}.o)
+      set_target_properties(${name} PROPERTIES
----------------
I would make that ${name}-lto.o just to make it clear what it is if someone looks at the directory and is concerned about that huge object file.


http://reviews.llvm.org/D15133





More information about the llvm-commits mailing list