[PATCH] D14690: Don't force std::set for SmallSet

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 11:42:30 PST 2015


chandlerc added inline comments.

================
Comment at: lib/Analysis/AliasAnalysisEvaluator.cpp:149
@@ -147,3 +148,3 @@
   SetVector<Value *> Pointers;
-  SetVector<CallSite> CallSites;
+  SetVector<CallSite, std::vector<CallSite>, std::set<CallSite>> CallSites;
   SetVector<Value *> Loads;
----------------
Why do we want a std::set here?

================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:1724
@@ -1723,3 +1723,3 @@
 
-static unsigned getConverterOperandID(const std::string &Name,
-                                      SetVector<std::string> &Table,
+typedef SetVector<std::string, std::vector<std::string>, std::set<std::string>>
+    StringSet;
----------------
Why not let this use DenseSet?


Repository:
  rL LLVM

http://reviews.llvm.org/D14690





More information about the llvm-commits mailing list