[PATCH] D14948: [X86] Use precise CFI for pushes by default

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 06:11:51 PST 2015


rafael added inline comments.

================
Comment at: include/llvm/CodeGen/MachineModuleInfo.h:168
@@ -167,1 +167,3 @@
 
+  /// UsePreciseUnwindInfo - True if we should emit precise CFA adjustment
+  /// information. False if we only need CFA to be precise at call sites.
----------------
Don't repeat name in comment.

================
Comment at: include/llvm/CodeGen/MachineModuleInfo.h:249
@@ -242,1 +248,3 @@
+  bool usePreciseUnwindInfo() const { return UsePreciseUnwindInfo; }
+  void setUsePreciseUnwindInfo(bool b) { UsePreciseUnwindInfo = b; }
 
----------------
Nothing calls this, so it is dead code.

Do you have a followup patch that uses it?


http://reviews.llvm.org/D14948





More information about the llvm-commits mailing list