[PATCH] D15110: Fixed a bug in FP logic operation lowering on AVX-512

Demikhovsky, Elena via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 01:11:38 PST 2015

I can't enable FABS before I fix ANDPS.
I can fix the ANDPS, but I don't know how to test it without FABS.

-  Elena

-----Original Message-----
From: Manman Ren [mailto:manman.ren at gmail.com] 
Sent: Wednesday, December 02, 2015 00:22
To: Demikhovsky, Elena <elena.demikhovsky at intel.com>; craig.topper at gmail.com
Cc: manman.ren at gmail.com; llvm-commits at lists.llvm.org
Subject: Re: [PATCH] D15110: Fixed a bug in FP logic operation lowering on AVX-512

manmanren added a subscriber: manmanren.
manmanren added a comment.

FP logic instructions are supported in DQ extension on AVX-512 target.
We can use integer operations instead.
Added tests.
I also enabled FABS in this patch in order to check ANDPS.

--> Is it possible to separate enabling of FABS?


Comment at: ../lib/Target/X86/X86ISelLowering.cpp:26171
@@ +26170,3 @@
+  if (VT.is512BitVector() && !Subtarget->hasDQI()) {
+    // VXORPS, VORPS, VANDPS, VANDNPS are supported only under DQ extention
+    // These logic operations may be executed in the integer domain.
Nit: period at end.

Comment at: ../lib/Target/X86/X86ISelLowering.cpp:26182
@@ +26181,3 @@
+      default:
+        assert("Unexpected FP logic op");
+        break;
Nit: llvm_unreachable?



Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

More information about the llvm-commits mailing list