[llvm] r254492 - [llvm-dwp] Don't rely on implicit move assignment operator (MSVC won't synthesize one)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 1 23:09:27 PST 2015


Author: dblaikie
Date: Wed Dec  2 01:09:26 2015
New Revision: 254492

URL: http://llvm.org/viewvc/llvm-project?rev=254492&view=rev
Log:
[llvm-dwp] Don't rely on implicit move assignment operator (MSVC won't synthesize one)

Modified:
    llvm/trunk/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp

Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp?rev=254492&r1=254491&r2=254492&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp (original)
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp Wed Dec  2 01:09:26 2015
@@ -31,8 +31,13 @@ void DWARFUnitIndex::Header::dump(raw_os
 
 bool DWARFUnitIndex::parse(DataExtractor IndexData) {
   bool b = parseImpl(IndexData);
-  if (!b)
-    *this = DWARFUnitIndex(InfoColumnKind);
+  if (!b) {
+    // Make sure we don't try to dump anything
+    Header.NumBuckets = 0;
+    // Release any partially initialized data.
+    ColumnKinds.reset();
+    Rows.reset();
+  }
   return b;
 }
 




More information about the llvm-commits mailing list