[PATCH] D15057: [PGO] Enable common VP format in profile runtime

[David Li via llvm-commits]

davidxl marked 3 inline comments as done.

================
Comment at: lib/profile/InstrProfiling.c:117
@@ +116,3 @@
+    }
+  }
+}
----------------
vsk wrote:
> Is `Data->Values` supposed to be free'd at some point?
Fixed.

================
Comment at: test/profile/instrprof-value-prof.c:4
@@ +3,3 @@
+// RUN: llvm-profdata merge -o %t.profdata %t.profraw
+// RUN: llvm-profdata show --all-functions -ic-targets  %t.profdata | FileCheck
+// %s
----------------
vsk wrote:
> I might be doing this incorrectly but I get a syntax error here. Doesn't this need to be:
> 
>     // RUN: llvm-profdata show --all-functions -ic-targets  %t.profdata | FileCheck \
>     // RUN: %s
Clang format did this, I think. Fixed.

================
Comment at: test/profile/instrprof-value-prof.c:95
@@ +94,3 @@
+// CHECK-NEXT: Indirect Target Results:
+// CHECK-NEXT:  [ 1, callee_2_2_2, 1 ]
+// CHECK-NEXT:  [ 2, callee_2_2_2, 1 ]
----------------
vsk wrote:
> Will the CHECK lines break if the assumed mapping between function names and addresses changes?
Right - the callee address sorting should be removed. This is fixed now -- as the callee targets are properly ordered according to how the initializer for calleeAddr array is defined.


http://reviews.llvm.org/D15057