[PATCH] D14983: Introduce new @llvm.getdynamicareaoffset.i{32, 64} intrinsic.

[hfinkel@anl.gov via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

A few more wording/naming things, otherwise, LGTM.


================
Comment at: docs/LangRef.rst:9350
@@ +9349,3 @@
+
+      declare i32 @llvm.getdynamicareaoffset.i32()
+      declare i64 @llvm.getdynamicareaoffset.i64()
----------------
We're somewhat inconsistent about this, but we mostly separate words in intrinsic names with periods, and I think we should do that here as well.

  llvm.get.dynamic.area.offset.*


================
Comment at: docs/LangRef.rst:9360
@@ +9359,3 @@
+      intendend for use in combination with
+      :ref:`llvm.stackrestore <int_stackrestore>` to get a
+      pointer to the most recent dynamic alloca. This is useful, for example,
----------------
Do you mean llvm.stacksave?

================
Comment at: docs/LangRef.rst:9373
@@ +9372,3 @@
+      complicated, because substracting this value from stack pointer would get the address
+      one past the end of the most-recent dynamic alloca.
+
----------------
most-recent -> most recent

[I know, I'm correcting my suggestion from the previous review]

================
Comment at: docs/LangRef.rst:9377
@@ +9376,3 @@
+      returns just a zero, for others, such as PowerPC and PowerPC64, it returns a
+      compile-time known constant value.
+
----------------
compile-time known -> compile-time-known

================
Comment at: docs/LangRef.rst:9380
@@ +9379,3 @@
+      The return value type of :ref:`llvm.getdynamicareaoffset <int_getdynamicareaoffset>`
+      must match generic address space's (address space 0) pointer type for given target,
+      otherwise LLVM would issue an error on the lowering stage.
----------------
must match generic -> must match the target's generic

remove "for given target"

================
Comment at: docs/LangRef.rst:9381
@@ +9380,3 @@
+      must match generic address space's (address space 0) pointer type for given target,
+      otherwise LLVM would issue an error on the lowering stage.
+
----------------
Remove ", otherwise LLVM would issue an error on the lowering stage" -- the LangRef does not define how LLVM responds to invalid input.


http://reviews.llvm.org/D14983