[PATCH] D14986: Fix Thumb1 epilogue generation

[Quentin Colombet via llvm-commits]

qcolombet added inline comments.

================
Comment at: lib/Target/ARM/Thumb1FrameLowering.cpp:456
@@ +455,3 @@
+          MO.getReg() != ARM::LR)
+        MIB.addOperand(MO);
+    MIB.addReg(ARM::PC, RegState::Define);
----------------
Do you actually need that loop instead of the copyImplicitOps call?
If so, add a comment explaining why.

================
Comment at: lib/Target/ARM/Thumb1FrameLowering.cpp:458
@@ -441,1 +457,3 @@
+    MIB.addReg(ARM::PC, RegState::Define);
+    // erase the old instruction (tBX_RET or tPOP)
     MBB.erase(MBBI);
----------------
Period.


http://reviews.llvm.org/D14986