[PATCH] D14909: [X86][FMA] Optimize FNEG(FMUL) Patterns

Steve Canon via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 11:31:22 PST 2015


scanon added a comment.

In http://reviews.llvm.org/D14909#298759, @spatel wrote:

> Can we assume default rounding for now, change the operand to X86::FNMSUB, remove the nsz check, and leave a 'TODO' comment to revisit this after rounding mode support is added? I think it would be better to have this transform be more general if we can.


I would *really* prefer not to.  Not having rounding-mode support means that we should do the conservative thing.  Once we have the ability to do the right thing, we can make the default more aggressive.


Repository:
  rL LLVM

http://reviews.llvm.org/D14909





More information about the llvm-commits mailing list