[PATCH] D14986: Fix Thumb1 epilogue generation

Jonathan Roelofs via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 08:56:02 PST 2015


jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D14986#297333, @tyomitch wrote:

> > This ^ does not look correct for v4t, which doesn't support changing the thumb 
>
> >  bit via a pop into pc.
>
>
> That's right, it isn't -- same as thumb1_return_sequence.ll is incorrect for v4T.
>
> I have a fix for v4T locally, but perhaps we can commit this fix (for v5T, broken since last week) now, and the fix for v4T (broken since July) in a separate, follow-up commit?
>  The two fixes are more or less independent.


Sounds reasonable to me.


http://reviews.llvm.org/D14986





More information about the llvm-commits mailing list