[PATCH] D14996: [WinEH] Avoid infinite loop in BranchFolding for multiple single block funclets

Joseph Tremoulet via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 08:41:44 PST 2015


JosephTremoulet added inline comments.

================
Comment at: lib/CodeGen/BranchFolding.cpp:1578
@@ +1577,3 @@
+          // already at the end.
+          while (MBB != InsertAfter && InsertAfter->isEHFuncletEntry() &&
+                 (InsertAfter->succ_empty() || !MBB->succ_empty()))
----------------
Basically I'm wishing this could be `InsertAfter is a block which will reach this codepath` instead of `InsertAfter->IsEHFuncletEntry()`, though I don't know how one would (or if one could) express that...


Repository:
  rL LLVM

http://reviews.llvm.org/D14996





More information about the llvm-commits mailing list