[PATCH] D15049: [asan] Skip all non-shared objects in FindFirstDSOCallback.

Dan McGregor via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 07:44:17 PST 2015


dankm added inline comments.

================
Comment at: lib/asan/CMakeLists.txt:68
@@ -71,2 +67,3 @@
 append_list_if(COMPILER_RT_HAS_LIBPTHREAD pthread ASAN_DYNAMIC_LIBS)
+append_list_if(COMPILER_RT_HAS_LIBRT rt ASAN_DYNAMIC_LIBS)
 append_list_if(COMPILER_RT_HAS_LIBSTDCXX stdc++ ASAN_DYNAMIC_LIBS)
----------------
dim wrote:
> So where did libc itself go? Was it actually needed?
It's not needed, at least on FreeBSD. It implicitly links against libc. The resulting shared object has libc last in its DT_NEEDED set.


http://reviews.llvm.org/D15049





More information about the llvm-commits mailing list