[PATCH] D14789: libc++abi: mark visibility

[Marshall Clow via llvm-commits]

mclow.lists added a comment.

This looks fine to me.

A note - the pervasive whitespace changes obscure the substantive changes.
In an ideal world, they would be two different changes.


================
Comment at: include/__cxxabi_config.h:24
@@ +23,3 @@
+
+#if defined(_LIBCXXABI_DLL)
+ #if defined(cxxabi_EXPORTS)
----------------
I'm wondering where you see use of `LIBCPP_DLL` in libc++.

The only place I see is in __config:182, which uses `_LIBCPP_DLL`, and has since (at least) 2011.

(Because @jroelofs is correct)



http://reviews.llvm.org/D14789