[PATCH] D14300: MSP430 calling convention updates

Youssefi, Anna via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 06:44:55 PST 2015


Please note that there are a couple errors in the ABI document.
First, no one is currently passing small structs in registers (GCC or TI) as the document states.  
Second, a couple of the C helper functions are listed incorrectly.  __mspabi_divlu and __mspabi_divllu should be __mspabi_divul and __mspabi_divull.  I have local work implementing the C helper function api but it has not yet been submitted for review and in the meantime, GCC has corrected these 2 in a patch as well. 

There is also still an omission in the passing of struct args-- the address of the struct should be passed as an argument, which is currently not implemented.

Also, please note that we are stalled on committing this patch until my supervisor gets some additional feedback on patent issues.

Thanks,
Anna Youssefi

-----Original Message-----
From: Meador Inge [mailto:meadori at gmail.com] 
Sent: Wednesday, November 25, 2015 7:37 AM
To: Youssefi, Anna; anton at korobeynikov.info
Cc: meadori at gmail.com; iains-llvm at btconnect.com; llvm-commits at lists.llvm.org
Subject: Re: [PATCH] D14300: MSP430 calling convention updates

meadori added a subscriber: meadori.
meadori added a comment.

> Is the ABI documented somewhere public?


http://www.ti.com/lit/an/slaa534/slaa534.pdf


http://reviews.llvm.org/D14300





More information about the llvm-commits mailing list