[PATCH] D15073: [sanitizer] Restore stderr when using forkpty() to spawn external symbolizer

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 30 03:49:38 PST 2015


dvyukov added a comment.

LGTM with a nit


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:95
@@ +94,3 @@
+      // Restore stderr.
+      CHECK_GE(dup2(saved_stderr, STDERR_FILENO), 0);
+
----------------
add close(saved_stderr) after this line just for completeness


http://reviews.llvm.org/D15073





More information about the llvm-commits mailing list