[PATCH] D14908: [IndVars] Preserve LCSSA on inner loops

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 29 14:38:14 PST 2015


sanjoy abandoned this revision.
sanjoy added a comment.

Hi Hal,

Thank you for the review.

After taking a closer look I think I've found the two specific things that need to be fixed to have `-indvars` preserve LCSSA for the entire loop nest.  Given that the two fixes are not very invasive, I think brute-forcing LCSSA after `-indvars` (i.e. this patch) is not the right fix.  I have the two new fixes up for review at http://reviews.llvm.org/D15058 and http://reviews.llvm.org/D15059.

The comment I made about SCEVExpander was also misleading -- at least in the breaking test cases, SCEVExpander does not break LCSSA for the inner loops, but it is `-indvars` that is the problem.

I'm abandoning this revision for now in favor of http://reviews.llvm.org/D15058 and http://reviews.llvm.org/D15059.


http://reviews.llvm.org/D14908





More information about the llvm-commits mailing list